Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968Ab1DMGX0 (ORCPT ); Wed, 13 Apr 2011 02:23:26 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:33912 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126Ab1DMGXZ (ORCPT ); Wed, 13 Apr 2011 02:23:25 -0400 Date: Wed, 13 Apr 2011 08:23:16 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Russell King - ARM Linux Cc: Richard Purdie , Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, kernel@pengutronix.de, Andrew Morton , H Hartley Sweeten , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] leds: provide helper to register "leds-gpio" devices Message-ID: <20110413062316.GH18850@pengutronix.de> References: <1302097097.22904.41.camel@rex> <1302554157-24145-1-git-send-email-u.kleine-koenig@pengutronix.de> <20110412214848.GI7806@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110412214848.GI7806@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 49 Hello, On Tue, Apr 12, 2011 at 10:48:48PM +0100, Russell King - ARM Linux wrote: > On Mon, Apr 11, 2011 at 10:35:57PM +0200, Uwe Kleine-K?nig wrote: > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > > index 9bec869..e8e101e 100644 > > --- a/drivers/leds/Kconfig > > +++ b/drivers/leds/Kconfig > > @@ -14,6 +14,11 @@ config LEDS_CLASS > > This option enables the led sysfs class in /sys/class/leds. You'll > > need this to do anything useful with LEDs. If unsure, say N. > > > > +config LED_REGISTER_GPIO > > + bool > > + help > > + This option provides the function gpio_led_register_device. > > + > > if NEW_LEDS > > > > comment "LED drivers" > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > index 39c80fc..ca428bd 100644 > > --- a/drivers/leds/Makefile > > +++ b/drivers/leds/Makefile > > @@ -3,6 +3,7 @@ > > obj-$(CONFIG_NEW_LEDS) += led-core.o > > obj-$(CONFIG_LEDS_CLASS) += led-class.o > > obj-$(CONFIG_LEDS_TRIGGERS) += led-triggers.o > > +obj-y += led-register.o > > Why not obj-$(CONFIG_LED_REGISTER_GPIO) += led-register.o > > rather than wrapping the code of led-register.c with a #ifdef for the > same symbol? I thought that the registration for other led-devices could go into that file, too. That's why I choosed the name led-register and not leds-gpio-register.c. Agreed? I don't insist on that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/