Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757312Ab1DMPLn (ORCPT ); Wed, 13 Apr 2011 11:11:43 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45756 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757112Ab1DMPLm convert rfc822-to-8bit (ORCPT ); Wed, 13 Apr 2011 11:11:42 -0400 From: "Nori, Sekhar" To: Ben Gardiner , "davinci-linux-open-source@linux.davincidsp.com" , "linux-i2c@vger.kernel.org" , Ben Dooks CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Bastian Ruppert , "Griffis, Brad" , Jon Povey , Philby John , Ben Dooks Date: Wed, 13 Apr 2011 20:40:37 +0530 Subject: RE: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci Thread-Topic: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci Thread-Index: Acvz2cVCBjL9aosGQQaO9rn+vyIxMAGEiy8g Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 45 Hi Ben, On Wed, Apr 06, 2011 at 03:08:09, Ben Gardiner wrote: > Both the da850 and da830 have an I2C controller which has the ICPFUNC > registers. Indicate this for all da830 and da850 boards by setting the > has_pfunc flag true in the da8xx utility setup routine for registering the > I2C controller > > Signed-off-by: Ben Gardiner > Cc: Sekhar Nori > Cc: Ben Dooks > > --- > arch/arm/mach-davinci/devices-da8xx.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c > index beda8a4..da01558 100644 > --- a/arch/arm/mach-davinci/devices-da8xx.c > +++ b/arch/arm/mach-davinci/devices-da8xx.c > @@ -324,6 +324,12 @@ int __init da8xx_register_i2c(int instance, > else > return -EINVAL; > > + /* > + * Both the DA850 and DA830 have an I2C controller which has the > + * ICPFUNC et. al. registers > + */ > + pdata->has_pfunc = 1; The I2C driver implements a default platform data so it should actually be legal for a DA8x board to pass NULL platform data. In that case this line will crash. You should either check for pdata to be NULL or just let each board choose whether it needs recovery (I think the better option). Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/