Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757304Ab1DMPN2 (ORCPT ); Wed, 13 Apr 2011 11:13:28 -0400 Received: from void.printf.net ([89.145.121.20]:53223 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757112Ab1DMPN1 convert rfc822-to-8bit (ORCPT ); Wed, 13 Apr 2011 11:13:27 -0400 From: Chris Ball To: Petr =?utf-8?B?UMOtc2HFmQ==?= Cc: Greg Kroah-Hartman , Alan Cox , linux-kernel@vger.kernel.org, Artem Bityutskiy Subject: Re: [PATCH] Clean console safely References: <1302705651.2768.21.camel@localhost> <1302706473-16519-1-git-send-email-ppisar@redhat.com> Date: Wed, 13 Apr 2011 11:18:04 -0400 In-Reply-To: <1302706473-16519-1-git-send-email-ppisar@redhat.com> ("Petr =?utf-8?B?UMOtc2HFmSIncw==?= message of "Wed, 13 Apr 2011 16:54:33 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1617 Lines: 46 Hi, On Wed, Apr 13 2011, Petr Písař wrote: > Traditional \E[2J sequence erases console display but scroll-back > buffer and underlying device (frame) buffer keep data that can be > accessed by scrolling console back. > > This patch introduce new \E[J parameter 3 that allows to scramble > scroll-back buffer explicitly. Session locking programs (screen, > vlock) can use it to prevent attacker to browse locked console > history. > > Signed-off-by: Petr Písař > --- > drivers/tty/vt/vt.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index 4bea1ef..fe96a1f 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -1197,6 +1197,12 @@ static void csi_J(struct vc_data *vc, int vpar) > vc->vc_x + 1); > } > break; > + case 3: /* erase scroll-back buffer (and whole display) */ > + scr_memsetw(vc->vc_screenbuf, vc->vc_video_erase_char, > + vc->vc_screenbuf_size >> 1); > + set_origin(vc); > + if (CON_IS_VISIBLE(vc)) > + update_screen(vc); > case 2: /* erase whole display */ > count = vc->vc_cols * vc->vc_rows; > start = (unsigned short *)vc->vc_origin; Nitpick: the cases were ordered before -- 3 should go after 2. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/