Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057Ab1DMVZz (ORCPT ); Wed, 13 Apr 2011 17:25:55 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:62264 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932495Ab1DMVZw (ORCPT ); Wed, 13 Apr 2011 17:25:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=oaQPkWJAwZ4VuFKxRxAkEFJJpEkiF0A4EwNzGqAzo3LblthdZxE+kar0NJ+na1W2eD 7XE4B/noe8eotdE3F7nY4RLBP6VpyjE/zPvG7uJRD1E4PHapZtylsuXmIFRiwP9gbU9n kzcGhe044VUONWs4PqoVUX2ryNRj8aA+q/0GM= Message-ID: <4DA614DF.5090304@openvz.org> Date: Thu, 14 Apr 2011 01:25:51 +0400 From: Cyrill Gorcunov User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: Don Zickus CC: Shaun Ruffell , maciej.rutecki@gmail.com, linux-kernel@vger.kernel.org, Ingo Molnar , Lin Ming , Peter Zijlstra , Stephane Eranian , Robert Richter Subject: Re: [regression 2.6.39-rc2][bisected] "perf, x86: P4 PMU - Read proper MSR register to catch" and NMIs References: <20110406223036.GA15721@digium.com> <201104132133.51958.maciej.rutecki@gmail.com> <4DA6011F.7070405@openvz.org> <20110413203501.GA10744@digium.com> <4DA60B03.30603@openvz.org> <20110413212208.GJ16939@redhat.com> In-Reply-To: <20110413212208.GJ16939@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1550 Lines: 38 On 04/14/2011 01:22 AM, Don Zickus wrote: > On Thu, Apr 14, 2011 at 12:43:47AM +0400, Cyrill Gorcunov wrote: >> On 04/14/2011 12:35 AM, Shaun Ruffell wrote: >> ... >>> >>> I had the first version of the patch running the test builds all night without >>> any NMIs. I installed this one and ran it through the case where I would >>> reliably get early NMIs and it still no NMIs. >>> >>> So for v2: >>> Tested-by: Shaun Ruffell >>> >>> Thanks! >> >> Thanks a huge Shaun. The thing is (if only I don't miss something) at moment there is >> no much difference in which patch to pick up. But as only kgdb dives in or any other >> subsystem (which say would use same manner of nmi delivery) we might be unmasking >> lvt entry even if nothing were handled at all, so I bias to a second version. > > I agree with the second version. Initially I wanted to enable it in the > case of the !handled path. But your reasoning makes sense to me, don't > enable it in the !handled case because you might accidentally do something > bad. > > Cheers, > Don OK, thanks for review! Shaun please continue testing it, if all will be fine until tomorrow we will ask Ingo to pick it up then. Sounds OK for everyone? (CC'ed a couple of people which were involved into this code snippet) -- Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/