Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751124Ab1DNEDr (ORCPT ); Thu, 14 Apr 2011 00:03:47 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:44058 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757Ab1DNEDp (ORCPT ); Thu, 14 Apr 2011 00:03:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=l+sX7l7y0jn8DULhdsiSppqV05OtoOIF7ru/OXRXhgrjOjUa/qx3RvfV+lt60TzQ05 VPxftJXYJ12V2UHll1gDuG/AFibjQYSMC+ogNoXl/QZeVjNKlAydlXY60j4JiYSPspBy Zg0RGMkbQ9D1Pl625vkkd0q8DbOCw567zxLqE= Date: Thu, 14 Apr 2011 13:03:37 +0900 From: Tejun Heo To: Linus Torvalds Cc: "H. Peter Anvin" , Yinghai Lu , Joerg Roedel , Ingo Molnar , Alex Deucher , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Thomas Gleixner Subject: Re: Linux 2.6.39-rc3 Message-ID: <20110414040337.GC12781@mtj.dyndns.org> References: <20110413172147.GI19819@8bytes.org> <4DA5F62F.3030504@kernel.org> <20110413193459.GL19819@8bytes.org> <4DA60C30.4060606@kernel.org> <4DA6145D.9070703@kernel.org> <4DA655E7.3000904@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 33 Hello, On Wed, Apr 13, 2011 at 07:33:40PM -0700, Linus Torvalds wrote: > On Wednesday, April 13, 2011, Linus Torvalds > wrote: > > On Wednesday, April 13, 2011, H. Peter Anvin wrote: > >> > >> Yes. ?However, even if we *do* revert (and the time is running short on > >> not reverting) I would like to understand this particular one, simply > >> because I think it may very well be a problem that is manifesting itself > >> in other ways on other systems. > > sorry, fingerfart. Anyway, I agree 100%. > > we definitely want to also understand the reason for things not > working, even if we do revert.. There were (and still are) places where memblock callers implemented ad-hoc top-down allocation by stepping down start limit until allocation succeeds. Several of them have been removed since top-down became the default behavior, so simply reverting the commit is likely to cause subtle issues. Maybe the best approach is introducing @topdown parameter and use it selectively for pure memory allocations. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/