Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757365Ab1DNJ1V (ORCPT ); Thu, 14 Apr 2011 05:27:21 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:32785 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402Ab1DNJ1T convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2011 05:27:19 -0400 From: "Nori, Sekhar" To: Mike Williamson CC: Ben Gardiner , "davinci-linux-open-source@linux.davincidsp.com" , "linux-i2c@vger.kernel.org" , Ben Dooks , "linux-kernel@vger.kernel.org" , Bastian Ruppert , Philby John , "linux-arm-kernel@lists.infradead.org" Date: Thu, 14 Apr 2011 14:56:38 +0530 Subject: RE: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci Thread-Topic: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci Thread-Index: Acv6Ly5Z/PZpOO+7R+C6Ohbe9KrF4wATkFKA Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 36 Hi Mike, On Thu, Apr 14, 2011 at 04:34:34, Mike Williamson wrote: > > The I2C driver implements a default platform data > > so it should actually be legal for a DA8x board to > > pass NULL platform data. In that case this line > > will crash. You should either check for pdata to > > be NULL or just let each board choose whether it > > needs recovery (I think the better option). > > > > I actually had a problem with using NULL for pdata with davinci I2C > and had submitted a patch here that sort of fell on the floor. The > problem was that the i2c_davinci_calc_clk_dividers is using > platform_data without a check as described above. So at the moment > using NULL doesn't really work, best as I can tell... > > https://lkml.org/lkml/2010/9/4/119 Looking at this mail chain, it looks like Ben was actually OK with your first submission and just wanted you to update the patch description saying that dev->platform_data is accessed later in the code and that is why it needs to be updated. I liked your first attempt better and may be you should try another submission with the patch description updated. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/