Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758649Ab1DNJpU (ORCPT ); Thu, 14 Apr 2011 05:45:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34241 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757422Ab1DNJpT (ORCPT ); Thu, 14 Apr 2011 05:45:19 -0400 Date: Thu, 14 Apr 2011 11:45:13 +0200 Message-ID: From: Takashi Iwai To: "Guido Trentalancia" Cc: linux-kernel@vger.kernel.org, kailang@realtek.com.tw, pshou@realtek.com.tw, jwoithe@physics.adelaide.edu.au Subject: Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops In-Reply-To: <201104071738.p37HcSFX019185@vivaldi20.register.it> References: <201104071738.p37HcSFX019185@vivaldi20.register.it> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 39 At Thu, 07 Apr 2011 19:38:27 +0200, Guido Trentalancia wrote: > > This quick fix to the Realtek HD Audio driver enables configurable support for the ALC271 type commonly found on some Acer laptops (e.g. Aspire 5745G). > > Normally, the driver would fall back to BIOS auto-probing. However, the "model=acer" parameter can be passed on the boot command line to enable such support. Otherwise, it is quite common that the internal microphone does not work. Well, adding the quirk label is fine, but this is no real fix. I can apply it with a different subject. Anyway, it's not such quite common that the machine doesn't work without the model quirk any longer :) In most cases, we want to avoid the model quirk but fixing the pin configuration instead. If the auto-parser doesn't work as is, please give alsa-info.sh output on your machine, and give the exact description what doesn't actually work. Then we can fix in a better way. thanks, Takashi > --- linux-2.6.38.2-original/sound/pci/hda/patch_realtek.c 2011-04-07 17:56:25.053046707 +0200 > +++ linux-2.6.38.2/sound/pci/hda/patch_realtek.c 2011-04-07 19:03:00.975706888 +0200 > @@ -15028,6 +15028,7 @@ static const char * const alc269_models[ > [ALC269_DMIC] = "laptop-dmic", > [ALC269_FUJITSU] = "fujitsu", > [ALC269_LIFEBOOK] = "lifebook", > + [ALC271_ACER] = "acer", > [ALC269_AUTO] = "auto", > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/