Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757543Ab1DNRaZ (ORCPT ); Thu, 14 Apr 2011 13:30:25 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:58316 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281Ab1DNRaY (ORCPT ); Thu, 14 Apr 2011 13:30:24 -0400 MIME-Version: 1.0 In-Reply-To: <201104141914.23529.bonganilinux@mweb.co.za> References: <201104051858.20304.bonganilinux@mweb.co.za> <201104141914.23529.bonganilinux@mweb.co.za> From: Linus Torvalds Date: Thu, 14 Apr 2011 10:29:34 -0700 Message-ID: Subject: Re: [Regression] 2.6.38 ncpfs To: Bongani Hlope Cc: npiggin@kernel.dk, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Greg KH , "Dr. Bernd Feige" , Petr Vandrovec , Arnd Bergmann , Christoph Hellwig Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 33 On Thu, Apr 14, 2011 at 10:14 AM, Bongani Hlope wrote: > > The bug is caused by commit fb2d5b86aff355a27ebfc132d3c99f4a940cc3fe, which > was committed by Nick. Can you please either revert Nick's changes or include > the attached patch (or a better version, because I'm not that clued up with > ncpfs). Hmm. Your patch isn't correct. You can't just do if (!mutex_is_locked(&dentry->d_inode->i_mutex)) { mutex_lock(&inode->i_mutex); because code like that makes no sense - maybe it was locked by somebody _else_, and you would need to lock it. That said, I do think that the BUG_ON(!mutex_is_locked(&dentry->d_inode->i_mutex)); is wrong, since even the comment above it talks about the _parent_ dentry, not the dentry that is actually being modified. So there's clearly a bug somewhere, and the fix may be to just remove that BUG_ON(). Added some more people to the cc. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/