Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933986Ab1DNTFZ (ORCPT ); Thu, 14 Apr 2011 15:05:25 -0400 Received: from slimlogic.co.uk ([89.16.172.20]:34473 "EHLO slimlogic.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573Ab1DNTFX convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2011 15:05:23 -0400 Subject: Re: [PATCH 3/4] TPS65910: IRQ: Add interrupt controller Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Jorge Eduardo Candelaria In-Reply-To: Date: Thu, 14 Apr 2011 14:05:18 -0500 Cc: linux-kernel@vger.kernel.org, broonie@opensource.wolfsonmicro.com, lrg@ti.com, sameo@linux.intel.com Content-Transfer-Encoding: 8BIT Message-Id: References: To: Thomas Gleixner X-Mailer: Apple Mail (2.1084) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 42 Hi Thomas, On Apr 14, 2011, at 11:22 AM, Thomas Gleixner wrote: > On Thu, 14 Apr 2011, Jorge Eduardo Candelaria wrote: >> +static void tps65910_irq_lock(unsigned int irq) >> +static void tps65910_irq_sync_unlock(unsigned int irq) >> +static void tps65910_irq_enable(unsigned int irq) >> +static void tps65910_irq_disable(unsigned int irq) >> + >> +static struct irq_chip tps65910_irq_chip = { >> + .name = "tps65910", >> + .irq_bus_lock = tps65910_irq_lock, >> + .irq_bus_sync_unlock = tps65910_irq_sync_unlock, >> + .irq_disable = tps65910_irq_disable, >> + .irq_enable = tps65910_irq_enable, >> +}; > > Care to explain how that compiles? I didn't notice it because there was no compilation error, however, I failed to see the following warnings: drivers/mfd/tps65910-irq.c:124: warning: initialization from incompatible pointer type drivers/mfd/tps65910-irq.c:125: warning: initialization from incompatible pointer type drivers/mfd/tps65910-irq.c:126: warning: initialization from incompatible pointer type drivers/mfd/tps65910-irq.c:127: warning: initialization from incompatible pointer type I'm changing this for v2. Thanks, Jorge > > Thanks, > > tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/