Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999Ab1DNUXe (ORCPT ); Thu, 14 Apr 2011 16:23:34 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60879 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308Ab1DNUXc convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2011 16:23:32 -0400 MIME-Version: 1.0 In-Reply-To: <201104142217.12478.bonganilinux@mweb.co.za> References: <201104051858.20304.bonganilinux@mweb.co.za> <201104141914.23529.bonganilinux@mweb.co.za> <201104142217.12478.bonganilinux@mweb.co.za> From: Linus Torvalds Date: Thu, 14 Apr 2011 13:22:38 -0700 Message-ID: Subject: Re: [Regression] 2.6.38 ncpfs To: Bongani Hlope Cc: npiggin@kernel.dk, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Greg KH , "Dr. Bernd Feige" , Petr Vandrovec , Arnd Bergmann , Christoph Hellwig Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 30 On Thu, Apr 14, 2011 at 1:17 PM, Bongani Hlope wrote: > > Looking at the changes, ?you are right. The BUG_ON() seems to be what is not > suppose to be there. The attached patch only removes the BUG_ON(). I'll test > on my work PC tomorrow and see if that also fixes the bug. You might also try to replace it with BUG_ON(!mutex_is_locked(&dentry->d_parent->d_inode->i_mutex)) ie add that "d_parent" there. Just for testing - I think the real fix really is to remove it, but I'd personally be happier knowing that _if_ it were to have that d_parent there, it would have worked. It would also be interesting to hear if that name length could possibly ever change, and we'd hit that test too. It looks like the original code actually checked that the length was the same before doing the overwrite. ncpfs doesn't seem to be very actively maintained, I suspect Petr isn't really using it any more. Linus Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/