Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487Ab1DNVnU (ORCPT ); Thu, 14 Apr 2011 17:43:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:4815 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774Ab1DNVnS (ORCPT ); Thu, 14 Apr 2011 17:43:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,213,1301900400"; d="scan'208";a="628808836" From: Darren Hart To: Linux Kernel Mailing List Cc: Linux Stable , Darren Hart , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Eric Dumazet , John Kacur Subject: [PATCH V4] futex: set FLAGS_HAS_TIMEOUT during demux for FUTEX_WAIT Date: Thu, 14 Apr 2011 14:43:01 -0700 Message-Id: X-Mailer: git-send-email 1.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 46 The FLAGS_HAS_TIMEOUT flag was not getting set, causing the restart_block to restart futex_wait() without a timeout after a signal. Commit b41277dc7a18ee332d in 2.6.38 introduced the regression by accidentally removing the the FLAGS_HAS_TIMEOUT assignment from futex_wait() during the setup of the restart block. Restore the originaly behavior. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=32922 V2: Added references to commit message. V3: Set flag during restart block instead of do_futex() V4: Correct stupid order of assignment mistake pointed out by Eric Signed-off-by: Darren Hart Reported-by: Tim Smith Reported-by: Torsten Hilbrich Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Ingo Molnar CC: Eric Dumazet CC: John Kacur --- kernel/futex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/futex.c b/kernel/futex.c index bda4157..abd5324 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1886,7 +1886,7 @@ retry: restart->futex.val = val; restart->futex.time = abs_time->tv64; restart->futex.bitset = bitset; - restart->futex.flags = flags; + restart->futex.flags = flags | FLAGS_HAS_TIMEOUT; ret = -ERESTART_RESTARTBLOCK; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/