DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=google.com; s=beta;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=s54j+07SsyaeKr+pp/YVaynd0IFCgWAfGvi0Wd8Hcz1Q+l9YO7XySSw7cl0fcyaWvq
         JsJdiwQKXWoOG5tDOnSA==
MIME-Version: 1.0
In-Reply-To: <4D9DFB08.8090206@codeaurora.org>
References: <1302131890-20953-1-git-send-email-sjg@chromium.org>
	<4D9DFB08.8090206@codeaurora.org>
Date: Thu, 14 Apr 2011 16:02:17 -0700
Message-ID: <BANLkTikRDowxG+q5tnhCCsCWCQEk-thqGg@mail.gmail.com>
Subject: Re: [PATCH v3] ARM: Use generic BUG() handler
From: Simon Glass <sjg@chromium.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org,
        Russell King <linux@arm.linux.org.uk>,
        Tony Lindgren <tony@atomide.com>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Joe Perches <joe@perches.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Alexander Shishkin <virtuoso@slind.org>,
        Phil Carmody <ext-phil.2.carmody@nokia.com>,
        Rabin Vincent <rabin@rab.in>, linux-kernel@vger.kernel.org,
        Omar Ramirez Luna <omar.ramirez@ti.com>,
        Dave Martin <dave.martin@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 935
Lines: 26

On Thu, Apr 7, 2011 at 10:57 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 04/06/2011 04:18 PM, Simon Glass wrote:
>> From: Simon Glass <sjg@google.com>
>>
>> ARM uses its own BUG() handler which makes its output slightly different
>> from other archtectures.
>>
> [snip]
>>
> Also, have you tried this with a module? I think you would at least need
> to modify arch/arm/kernel/module.c to hook up the module_bug_finalize()
> and module_bug_cleanup() stuff.

Actually this just works, except that I need to allow the PC to be
below PAGE_OFFSET where modules are loaded. This is a benefit of using
generic Linux code.

I have sent a new version of the patch to review.

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/