Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757241Ab1DOV0Z (ORCPT ); Fri, 15 Apr 2011 17:26:25 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:43474 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757129Ab1DOV0Y (ORCPT ); Fri, 15 Apr 2011 17:26:24 -0400 Date: Fri, 15 Apr 2011 17:26:00 -0400 From: Christoph Hellwig To: Linus Torvalds Cc: Peter Zijlstra , Christoph Hellwig , Dave Jones , Linux Kernel , William Irwin , Ingo Molnar Subject: Re: hugetlb locking bug. Message-ID: <20110415212600.GA3626@infradead.org> References: <20110415201652.GA5131@redhat.com> <20110415205712.GA13049@infradead.org> <1302901766.2035.39.camel@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 25 On Fri, Apr 15, 2011 at 02:19:01PM -0700, Linus Torvalds wrote: > On Fri, Apr 15, 2011 at 2:09 PM, Peter Zijlstra wrote: > > On Fri, 2011-04-15 at 16:57 -0400, Christoph Hellwig wrote: > >> > >> Because it doesn't use iget or unlock_new_inode, but rather calls > >> directly into new_inode(). ?It and other filesystems not using > >> unlock_new_inode will need a local copy of that logic. > > > > Is there a sane reason they do their own magic, and thus need a copy of > > the logic, instead of using the generic code that already has it? > > Hmm. That all seems to be just an oversight. > > Does this trivial one-liner work? > > (Warning: whitespace damage and TOTALLY UNTESTED) It'll get rid of the lockdep spat in favour of a WARN_ON, given that inodes from new_inode() never have I_NEW set. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/