Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759281Ab1DPKQP (ORCPT ); Sat, 16 Apr 2011 06:16:15 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:50653 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758554Ab1DPKQF convert rfc822-to-8bit (ORCPT ); Sat, 16 Apr 2011 06:16:05 -0400 Subject: Re: [PATCH 4/4] perf, x86: Fix event scheduler to solve complex scheduling problems From: Peter Zijlstra To: Ingo Molnar Cc: Robert Richter , Stephane Eranian , LKML , Arnaldo Carvalho de Melo , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker In-Reply-To: <20110416101406.GA11534@elte.hu> References: <1302913676-14352-1-git-send-email-robert.richter@amd.com> <1302913676-14352-5-git-send-email-robert.richter@amd.com> <1302943877.32491.9.camel@twins> <20110416094348.GA24711@elte.hu> <1302948520.32491.10.camel@twins> <20110416101406.GA11534@elte.hu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Sat, 16 Apr 2011 12:15:40 +0200 Message-ID: <1302948940.32491.12.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 23 On Sat, 2011-04-16 at 12:14 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > On Sat, 2011-04-16 at 11:43 +0200, Ingo Molnar wrote: > > > I'd also prefer if we first had actual testcases in 'perf test' for all these > > > failures - it took an *awfully* long time to find these regressions (the event > > > scheduler code has been committed for months), while with proper testcases it > > > would only take a second to run 'perf test'. > > > > These cases only exist on AMD F15, I don't think there's many people > > with such systems around. > > Well, if the trend continues we'll have more twisted constraints and more bugs > of this sort, so having a testsuite sure cannot hurt, right? For sure. But the problem with writing test cases at the perf userspace level is that they're very hardware specific. It would be much easier to write unit tests for the solver itself. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/