Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 20 Jul 2002 13:00:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 20 Jul 2002 13:00:21 -0400 Received: from holomorphy.com ([66.224.33.161]:24980 "EHLO holomorphy") by vger.kernel.org with ESMTP id ; Sat, 20 Jul 2002 13:00:20 -0400 Date: Sat, 20 Jul 2002 10:03:13 -0700 From: William Lee Irwin III To: Jari Ruusu Cc: Jens Axboe , Andrew Morton , Rik van Riel , linux-kernel@vger.kernel.org Subject: Re: [BUG] loop.c oopses Message-ID: <20020720170313.GE1096@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Jari Ruusu , Jens Axboe , Andrew Morton , Rik van Riel , linux-kernel@vger.kernel.org References: <20020716163636.GW811@suse.de> <20020716170921.GX811@suse.de> <3D34773C.F61E7C0F@pp.inet.fi> <20020717054006.GZ811@suse.de> <3D358DD8.D39F06FF@pp.inet.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: brief message Content-Disposition: inline In-Reply-To: <3D358DD8.D39F06FF@pp.inet.fi> User-Agent: Mutt/1.3.25i Organization: The Domain of Holomorphy Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 25 Jens Axboe wrote: > Both 2.4 and 2.5 have same two bugs: > 1) lo->lo_pending never decremented in remap case > 2) remapping _never_ enabled (and this caused it to appear to work) Jens Axboe wrote: >> That said, please do split up the patches as Andrew/wli suggested. For >> the 2.5 one I'd be inclined to just take it as-is, but the 2.4 patch >> definitely needs to be split. On Wed, Jul 17, 2002 at 06:31:36PM +0300, Jari Ruusu wrote: > OK. Since 2.5.25 patch still applies to 2.5.26 with one 3-line offset, I > won't send new one but comment the patch. Isn't it more usual to send the individual bugfixes/whatever as entirely separate patches? (I admit, this did explain quite a bit, though.) Cheers, Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/