From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2
Date: Sun, 17 Apr 2011 22:39:57 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; )
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, ohad@wizery.com,
        linus.walleij@stericsson.com, patches@linaro.org,
        linux-kernel@vger.kernel.org, lee.jones@linaro.org
References: <1302535464-12294-1-git-send-email-mathieu.poirier@linaro.org> <201104121946.01618.arnd@arndb.de> <4DA4A44D.5020208@linaro.org>
In-Reply-To: <4DA4A44D.5020208@linaro.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201104172239.57362.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1059
Lines: 24

On Tuesday 12 April 2011, Mathieu Poirier wrote:
> > struct u8500_hsem_state {
> >       void __iomem *io_base;
> >       struct u8500_hsem hsem[U8500_MAX_SEMAPHORE];
> > }
> I don't see the real advantage in doing a single allocation - the 
> dynamic allocation method is also used in 'omap_hwspinlock.c'.  Is 
> modification mandatory to get the driver accepted ?

Not strictly required, but somewhat cleaner IMHO. If you have a good
reason for splitting the allocations, just document that clearly.

One more thing I just noticed: the hwspinlock_internal.h file defines
the hwspinlock->id field as "a global, unique, system-wide, index of
the lock", but the u8500 hsem just sets it to an integer starting
at zero. If there are multiple devices providing hwspinlocks in the
same system, that cannot work.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/