Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752990Ab1DQU4e (ORCPT ); Sun, 17 Apr 2011 16:56:34 -0400 Received: from mail.perches.com ([173.55.12.10]:4784 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab1DQU42 (ORCPT ); Sun, 17 Apr 2011 16:56:28 -0400 Subject: Re: [PATCH 3/4] ata: Add and use ata_print_version_once From: Joe Perches To: saeed bishara Cc: Jeff Garzik , linux-ide@vger.kernel.org, Mikael Pettersson , linux-kernel@vger.kernel.org In-Reply-To: References: <440aa7f6bb99bec705b83796894f843bfc1b7bf9.1302907497.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 17 Apr 2011 13:56:26 -0700 Message-ID: <1303073786.31723.14.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 18 On Sun, 2011-04-17 at 13:45 +0300, saeed bishara wrote: > On Sat, Apr 16, 2011 at 1:52 AM, Joe Perches wrote: > > Use a single mechanism to show driver version. > > Reduces text a tiny bit too. > > Remove uses of static int printed_version > > Add and use ata_print_version(const struct device *, const char *ver) > > and ata_print_version_once. > any idea why we really need this driver version for in-kernel drivers? > isn't the kernel version good enough? Some think it useful to see what module version is linked against the kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/