Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147Ab1DRHdk (ORCPT ); Mon, 18 Apr 2011 03:33:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485Ab1DRHde (ORCPT ); Mon, 18 Apr 2011 03:33:34 -0400 Message-ID: <4DABE938.6020400@redhat.com> Date: Mon, 18 Apr 2011 09:33:12 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110403 Fedora/3.1.9-6.fc15 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: Natarajan Gurumoorthy CC: Guenter Roeck , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , Wim Van Sebroeck , Mike Waychison Subject: Re: [lm-sensors] [PATCH v6 1/2] Use "request_muxed_region" in it87 watchdog drivers References: <1302816996-6345-1-git-send-email-natg@google.com> <1302817069-6389-1-git-send-email-natg@google.com> <1302821370.26780.585.camel@groeck-laptop> <20110415024005.GA21642@ericsson.com> <20110415055852.GA21905@ericsson.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2047 Lines: 56 Hi, On 04/15/2011 10:46 AM, Natarajan Gurumoorthy wrote: > On Thu, Apr 14, 2011 at 10:58 PM, Guenter Roeck > wrote: >> I have seen the list. I don't think you should fix everything in one go. >> First step might be to get the w83697hf and it87 to work together, then >> go from there. >> >> Is there a reason for loading (or trying to load) both the it87 and >> the w83697hf driver at the same time ? Those drivers are usually only >> loaded if the respective chip is known to exist. If there is no reason >> to try loading both drivers, a simple workaround would be to not do it. >> > Guenter, > I agree the above should never happen. The only way the 2 > drivers will be loaded at the same time is a misconfigured kernel > where these 2 drivers get built and the rc scripts end up loading them > too. If we are agreed that I suggest we make the superio_enter routine > be the following: > > static inline void > superio_enter(void) > { > /* > * Reserve REG and REG + 1 for exclusive access. > */ > while (!request_muxed_region(REG, 2, WATCHDOG_NAME)) > continue; > Natajaran, Please stop being so stubborn. XXX people have told you not to put a while loop here, but simply to check for an error and propagate it (in all places where superio_enter gets called). Your bogus argument of the driver then failing to load when another non muxed superio driver loads is really far fetched. No system ever has 2 super io chips. So as long as all ite drivers use the muxed version all will be fine. And if some unforeseen scenario happens where the request_muxed_region fails, we will get a bug report about a driver failing to load (*). Which is a lot better for the end user then being stuck in an endless loop. Regards, Hans *) And deal with that then. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/