Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754300Ab1DRKmg (ORCPT ); Mon, 18 Apr 2011 06:42:36 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:50510 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754096Ab1DRKma (ORCPT ); Mon, 18 Apr 2011 06:42:30 -0400 Date: Mon, 18 Apr 2011 11:42:26 +0100 From: Jamie Iles To: Sonny Rao Cc: Jamie Iles , olofj@chromium.org, Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Russell King , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix infinite loop in ARM user perf_event backtrace code Message-ID: <20110418104226.GA2820@pulham.picochip.com> References: <1302924445-18557-1-git-send-email-sonnyrao@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1302924445-18557-1-git-send-email-sonnyrao@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 21 Hi, On Fri, Apr 15, 2011 at 08:27:25PM -0700, Sonny Rao wrote: > The ARM user backtrace code can get into an infinite loop if it > runs into an invalid stack frame which points back to itself. > This situation has been observed in practice. Fix it by capping > the number of entries in the backtrace. This is also what other > architectures do in their backtrace code. Tested on my v6k board and looks good. > Signed-off-by: Sonny Rao Acked-by: Jamie Iles Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/