Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262Ab1DRPnJ (ORCPT ); Mon, 18 Apr 2011 11:43:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754043Ab1DRPnG (ORCPT ); Mon, 18 Apr 2011 11:43:06 -0400 Date: Mon, 18 Apr 2011 11:42:13 -0400 From: "J. Bruce Fields" To: Linus Torvalds Cc: OGAWA Hirofumi , Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Neil Brown , linux-nfs@vger.kernel.org Subject: Re: [105/105] nfsd4: fix oops on lock failure Message-ID: <20110418154212.GD20935@pad.home.fieldses.org> References: <20110412143559.186613198@clark.kroah.org> <87pqokx6lr.fsf@devron.myhome.or.jp> <20110418153236.GC20935@pad.home.fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110418153236.GC20935@pad.home.fieldses.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 46 On Mon, Apr 18, 2011 at 11:32:36AM -0400, J. Bruce Fields wrote: > On Sun, Apr 17, 2011 at 09:10:12AM -0700, Linus Torvalds wrote: > > On Sun, Apr 17, 2011 at 8:03 AM, OGAWA Hirofumi > > wrote: > > > > > > I'm looking filp leak on recent kernel. Well, anyway, > > Does this fix it? (But, yes, I think your patch is almost certainly right as well. Gah--I've been introducing depressing number of regressions lately.) --b. > > --b. > > commit 5152c8a947359758862d4631863e68e83ec01048 > Author: J. Bruce Fields > Date: Fri Apr 15 18:08:26 2011 -0400 > > nfsd4: fix struct file leak on delegation > > Introduced by acfdf5c383b38f7f4dddae41b97c97f1ae058f49. > > Cc: stable@kernel.org > Reported-by: Gerhard Heift > Signed-off-by: J. Bruce Fields > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index aa309aa..c79a983 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -258,6 +258,7 @@ static void nfs4_put_deleg_lease(struct nfs4_file *fp) > if (atomic_dec_and_test(&fp->fi_delegees)) { > vfs_setlease(fp->fi_deleg_file, F_UNLCK, &fp->fi_lease); > fp->fi_lease = NULL; > + fput(fp->fi_deleg_file); > fp->fi_deleg_file = NULL; > } > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/