Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755657Ab1DRQKp (ORCPT ); Mon, 18 Apr 2011 12:10:45 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:50020 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755417Ab1DRQK3 (ORCPT ); Mon, 18 Apr 2011 12:10:29 -0400 From: OGAWA Hirofumi To: "J. Bruce Fields" Cc: Linus Torvalds , Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Neil Brown , linux-nfs@vger.kernel.org Subject: Re: [105/105] nfsd4: fix oops on lock failure References: <20110412143559.186613198@clark.kroah.org> <87pqokx6lr.fsf@devron.myhome.or.jp> <20110418153236.GC20935@pad.home.fieldses.org> <87ipubwnj3.fsf@devron.myhome.or.jp> Date: Tue, 19 Apr 2011 01:10:26 +0900 In-Reply-To: <87ipubwnj3.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Tue, 19 Apr 2011 01:08:00 +0900") Message-ID: <8762qbwnf1.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 49 OGAWA Hirofumi writes: > "J. Bruce Fields" writes: > >> On Sun, Apr 17, 2011 at 09:10:12AM -0700, Linus Torvalds wrote: >>> On Sun, Apr 17, 2011 at 8:03 AM, OGAWA Hirofumi >>> wrote: >>> > >>> > I'm looking filp leak on recent kernel. Well, anyway, >> >> Does this fix it? > > It seems to be no, unfortunately. filp leak is not so fast, and obvious > reproduce process is not known yet. Well, sigh, I'm starting to add > debugging code for it... Ah, I was missing patch itself. I'll see. > commit 5152c8a947359758862d4631863e68e83ec01048 > Author: J. Bruce Fields > Date: Fri Apr 15 18:08:26 2011 -0400 > > nfsd4: fix struct file leak on delegation > > Introduced by acfdf5c383b38f7f4dddae41b97c97f1ae058f49. > > Cc: stable@kernel.org > Reported-by: Gerhard Heift > Signed-off-by: J. Bruce Fields > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index aa309aa..c79a983 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -258,6 +258,7 @@ static void nfs4_put_deleg_lease(struct nfs4_file *fp) > if (atomic_dec_and_test(&fp->fi_delegees)) { > vfs_setlease(fp->fi_deleg_file, F_UNLCK, &fp->fi_lease); > fp->fi_lease = NULL; > + fput(fp->fi_deleg_file); > fp->fi_deleg_file = NULL; > } > } -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/