Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755802Ab1DRQeZ (ORCPT ); Mon, 18 Apr 2011 12:34:25 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:62291 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754099Ab1DRQeV (ORCPT ); Mon, 18 Apr 2011 12:34:21 -0400 X-Authority-Analysis: v=1.1 cv=aqMe+0lCtaYvy4h0jyaoPGyq+DPF+P6rPG2xbekoY9Q= c=1 sm=0 a=JTjb3um6TXYA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=OGiIHcdGOILrvgVQl6gA:9 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [RFC][PATCH 3/7] lockdep: Annotate read/write states From: Steven Rostedt To: Yong Zhang Cc: Peter Zijlstra , Ingo Molnar , LKML , Tetsuo Handa , Thomas Gleixner In-Reply-To: <20110418133405.GA2080@zhy> References: <20110417094505.865828233@chello.nl> <20110417095507.026186002@chello.nl> <20110418133405.GA2080@zhy> Content-Type: text/plain; charset="ISO-8859-15" Date: Mon, 18 Apr 2011 12:34:19 -0400 Message-ID: <1303144459.7181.42.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 28 On Mon, 2011-04-18 at 21:34 +0800, Yong Zhang wrote: > > Signed-off-by: Peter Zijlstra > > --- > > include/linux/lockdep.h | 107 ++++++++++++++++++++++++++++++++++++------------ > > kernel/lockdep.c | 46 ++++++++++---------- > > 2 files changed, 105 insertions(+), 48 deletions(-) > > > > @@ -2273,7 +2273,7 @@ mark_held_locks(struct task_struct *curr > > hlock = curr->held_locks + i; > > > > usage_bit = 2 + (mark << 2); /* ENABLED */ > > - if (hlock->read) > > + if (hlock->rw_state) > > is_read(hlock->rw_state) ? Yeah, I think this should be a is_read() or add a comment explaining why not. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/