Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756125Ab1DRRdB (ORCPT ); Mon, 18 Apr 2011 13:33:01 -0400 Received: from mail3.caviumnetworks.com ([12.108.191.235]:3064 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755925Ab1DRRcz (ORCPT ); Mon, 18 Apr 2011 13:32:55 -0400 Message-ID: <4DAC75C6.2060504@caviumnetworks.com> Date: Mon, 18 Apr 2011 10:32:54 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Kevin Cernekee CC: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] MIPS: Replace _PAGE_READ with _PAGE_NO_READ References: <7aa38c32b7748a95e814e5bb0583f967@localhost> In-Reply-To: <7aa38c32b7748a95e814e5bb0583f967@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 18 Apr 2011 17:32:54.0540 (UTC) FILETIME=[A65DCCC0:01CBFDEE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 27 On 04/16/2011 09:44 AM, Kevin Cernekee wrote: > Reuse more of the same definitions for the non-RIXI and RIXI cases. This > avoids having special cases for kernel_uses_smartmips_rixi cluttering up > the pgtable*.h files. > > On hardware that does not support RI/XI, EntryLo bits 31:30 / 63:62 will > remain unset and RI/XI permissions will not be enforced. > > Signed-off-by: Kevin Cernekee > --- > arch/mips/include/asm/pgtable-bits.h | 23 ++++++++--------------- > arch/mips/include/asm/pgtable.h | 21 ++++++++------------- > arch/mips/mm/tlbex.c | 17 +++++------------ > 3 files changed, 21 insertions(+), 40 deletions(-) > [...] I like this patch. How much testing have you done on non-RI/XI CPUs? David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/