Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752536Ab1DRU5K (ORCPT ); Mon, 18 Apr 2011 16:57:10 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:45109 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949Ab1DRU5H (ORCPT ); Mon, 18 Apr 2011 16:57:07 -0400 Subject: Re: [PATCH 1/2] break out page allocation warning code From: Dave Hansen To: David Rientjes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Nazarewicz , Andrew Morton In-Reply-To: References: <20110415170437.17E1AF36@kernel> <1303139455.9615.2533.camel@nimitz> Content-Type: text/plain; charset="ISO-8859-1" Date: Mon, 18 Apr 2011 13:57:01 -0700 Message-ID: <1303160221.9887.301.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 17 On Mon, 2011-04-18 at 13:25 -0700, David Rientjes wrote: > It shouldn't be a follow-on patch since you're introducing a new feature > here (vmalloc allocation failure warnings) and what I'm identifying is a > race in the access to current->comm. A bug fix for a race should always > preceed a feature that touches the same code. Dude. Seriously. Glass house! a63d83f4 I'll go look in to it, though. -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/