Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651Ab1DRU5T (ORCPT ); Mon, 18 Apr 2011 16:57:19 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45664 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949Ab1DRU5M (ORCPT ); Mon, 18 Apr 2011 16:57:12 -0400 Date: Mon, 18 Apr 2011 13:56:37 -0700 From: Andrew Morton To: Michal Hocko Cc: Hugh Dickins , linux-mm@kvack.org, LKML Subject: Re: [PATCH v2] mm: make expand_downwards symmetrical to expand_upwards Message-Id: <20110418135637.5baac204.akpm@linux-foundation.org> In-Reply-To: <20110418100131.GD8925@tiehlicka.suse.cz> References: <20110415135144.GE8828@tiehlicka.suse.cz> <20110418100131.GD8925@tiehlicka.suse.cz> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 23 On Mon, 18 Apr 2011 12:01:31 +0200 Michal Hocko wrote: > Currently we have expand_upwards exported while expand_downwards is > accessible only via expand_stack or expand_stack_downwards. > > check_stack_guard_page is a nice example of the asymmetry. It uses > expand_stack for VM_GROWSDOWN while expand_upwards is called for > VM_GROWSUP case. > > Let's clean this up by exporting both functions and make those name > consistent. Let's use expand_stack_{upwards,downwards} so that we are > explicit about stack manipulation in the name. expand_stack_downwards > has to be defined for both CONFIG_STACK_GROWS{UP,DOWN} because > get_arg_page calls the downwards version in the early process > initialization phase for growsup configuration. Has this patch been tested on any stack-grows-upwards architecture? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/