Date: Mon, 18 Apr 2011 17:48:18 -0400
From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: jaxboe@fusionio.com, torvalds@linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: block: add blk_run_queue_async
Message-ID: <20110418214818.GA2217@redhat.com>
References: <20110418092647.GB3837@infradead.org>
 <BANLkTikOKji3_p+bqMO4zoSnXFunEdue0g@mail.gmail.com>
 <20110418195929.GA9650@infradead.org>
 <20110418202053.GA29394@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110418202053.GA29394@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1309
Lines: 34

On Mon, Apr 18 2011 at  4:20pm -0400,
Mike Snitzer <snitzer@redhat.com> wrote:

> On Mon, Apr 18 2011 at  3:59pm -0400,
> Christoph Hellwig <hch@infradead.org> wrote:
> 
> > On Mon, Apr 18, 2011 at 03:55:04PM -0400, Mike Snitzer wrote:
> > > > +{
> > > > + ? ? ? if (likely(!blk_queue_stopped(q)))
> > > > + ? ? ? ? ? ? ? queue_delayed_work(kblockd_workqueue, &q->delay_work, 0);
> > > 
> > > I know Jens already queued this up 'for-linus' but why not use
> > > kblockd_schedule_work(q, &q->delay_work)?
> > 
> > I don't see what that would buy us.  If we'd absolutely want a wrapper
> > a blk_delay_queue(q, 0) in Jens' current tree would do it now that is
> > has been fixed up to use the kblockd workqueue.
> 
> Right, I missed 4521cc4 block: blk_delay_queue() should use kblockd
> workqueue.  So why not use blk_delay_queue()?
> 
> I agree with Jens that it doesn't much matter but I also cannot see it
> being a bad thing.. I'd prefer it ;)
> 
> *shrug*

Also, FYI, I'm seeing a leftover '@force_kblockd: ...' comment in the
__blk_run_queue's comment block.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/