Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753497Ab1DRXFn (ORCPT ); Mon, 18 Apr 2011 19:05:43 -0400 Received: from mail.perches.com ([173.55.12.10]:4817 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893Ab1DRXFl (ORCPT ); Mon, 18 Apr 2011 19:05:41 -0400 Subject: Re: [PATCH 1/2] drm: Create and use drm_err From: Joe Perches To: Ian Romanick Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <4DACC1B1.8090808@freedesktop.org> References: <4DACC1B1.8090808@freedesktop.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 18 Apr 2011 16:05:39 -0700 Message-ID: <1303167939.31723.47.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 27 On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote: > I believe that DRM_NAME is a define, and drm_stub.c is in common code. > As a result, won't this change cause something different to get logged? Nope. DRM_NAME is #defined only once. include/drm/drm.h:#define DRM_NAME "drm" The only real reason to do this is the "*ERROR*" used in: > > -#define DRM_ERROR(fmt, arg...) \ > > - printk(KERN_ERR "[" DRM_NAME ":%s] *ERROR* " fmt , __func__ , ##arg) It'd be more or less similar to use: #define DRM_ERROR(fmt, ...) \ pr_err("%s: " fmt, __func__, ##__VA_ARGS__) or just convert DRM_ERROR to pr_err and DRM_INFO to pr_info. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/