Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688Ab1DSGEx (ORCPT ); Tue, 19 Apr 2011 02:04:53 -0400 Received: from eu1sys200aog103.obsmtp.com ([207.126.144.115]:55652 "EHLO eu1sys200aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167Ab1DSGEu (ORCPT ); Tue, 19 Apr 2011 02:04:50 -0400 Message-ID: <4DAD25E7.4030602@st.com> Date: Tue, 19 Apr 2011 11:34:23 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Linus Walleij Cc: "linux-kernel@vger.kernel.org" , Vinod Koul , Dan Williams , "linux-arm-kernel@lists.infradead.org" , amitgoel , Armando VISCONTI , Shiraz HASHIM , "linux-serial@vger.kernel.org" , "viresh.linux@gmail.com" Subject: Re: [PATCH] dmaengine: implement pause and resume for dw_dmac References: <1303173092-21785-1-git-send-email-linus.walleij@linaro.org> <4DAD1DA5.7010801@st.com> In-Reply-To: <4DAD1DA5.7010801@st.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 28 On 04/19/2011 10:59 AM, viresh kumar wrote: > On 04/19/2011 06:01 AM, Linus Walleij wrote: >> > It seems that the SPEAr needs this. >> > >> > Signed-off-by: Linus Walleij > Thanks for sending this. > Actually i wasn't sure that disabling channel will simply pause it, and not > finish the transfer. So, didn't went for this change. > >> > --- >> > drivers/dma/dw_dmac.c | 22 ++++++++++++++++++++-- >> > drivers/dma/dw_dmac_regs.h | 1 + >> > 2 files changed, 21 insertions(+), 2 deletions(-) Moreover, dwc_tx_status() must be updated to add following code: if (dwc->paused) return DMA_PAUSED; Will do that while sending it in my patchset. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/