Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700Ab1DSGXz (ORCPT ); Tue, 19 Apr 2011 02:23:55 -0400 Received: from eu1sys200aog109.obsmtp.com ([207.126.144.127]:56460 "EHLO eu1sys200aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251Ab1DSGXx (ORCPT ); Tue, 19 Apr 2011 02:23:53 -0400 Message-ID: <4DAD2A61.4020406@st.com> Date: Tue, 19 Apr 2011 11:53:29 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: "Koul, Vinod" Cc: "linux-kernel@vger.kernel.org" , "Williams, Dan J" , "linux-arm-kernel@lists.infradead.org" , Armando VISCONTI , Shiraz HASHIM , amitgoel , "viresh.linux@gmail.com" , "jamie@jamieiles.com" , "linux@arm.linux.org.uk" Subject: Re: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine. References: <438BB0150E931F4B9CE701519A44630108519E1BE6@bgsmsx502.gar.corp.intel.com> In-Reply-To: <438BB0150E931F4B9CE701519A44630108519E1BE6@bgsmsx502.gar.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 28 On 04/19/2011 11:42 AM, Koul, Vinod wrote: > On 04/18/2011 04:20 PM, viresh kumar wrote: >> >> Resubmission of new transfer must be allowed from callbacks. For this release >> lock before calling callback routine and enable them again. > Why would you like to do that? > > IMO it's not a good thing as you are essentially doing it in your tasklet... > Make sure the submit() is done by client before this and you use it to start > next transaction in you tasklet and let client know in callback txn is > finished. > Vinod, I initiated this discussion few days back on a separate thread: http://www.spinics.net/lists/arm-kernel/msg121139.html And so implemented this. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/