Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849Ab1DSG0I (ORCPT ); Tue, 19 Apr 2011 02:26:08 -0400 Received: from eu1sys200aog113.obsmtp.com ([207.126.144.135]:45809 "EHLO eu1sys200aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278Ab1DSG0F (ORCPT ); Tue, 19 Apr 2011 02:26:05 -0400 Message-ID: <4DAD2AE9.7060106@st.com> Date: Tue, 19 Apr 2011 11:55:45 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: "vinod.koul@intel.com" , "dan.j.williams@intel.com" Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Armando VISCONTI , Shiraz HASHIM , amitgoel , "viresh.linux@gmail.com" , "jamie@jamieiles.com" , "linux@arm.linux.org.uk" Subject: Re: [PATCH 1/6] dmaengine/dw_dmac: Replace spin_lock_bh with irqsave variants References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 33 On 04/18/2011 04:19 PM, Viresh KUMAR wrote: > dmaengine routines can be called from interrupt context and with interrupts > disabled. Whereas spin_unlock_bh can't be called from such contexts. So this > patch converts all spin_*_bh routines to irqsave variants. > > Signed-off-by: Viresh Kumar > --- > drivers/dma/dw_dmac.c | 56 +++++++++++++++++++++++++------------------ > drivers/dma/dw_dmac_regs.h | 1 + > 2 files changed, 33 insertions(+), 24 deletions(-) > > > diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h > index 720f821..c89fd83 100644 > --- a/drivers/dma/dw_dmac_regs.h > +++ b/drivers/dma/dw_dmac_regs.h > @@ -173,6 +173,7 @@ struct dw_dma { > void __iomem *regs; > struct tasklet_struct tasklet; > struct clk *clk; > + unsigned long flags; /* for spin_lock_irqsave */ Oops!!! This must have been added in dw_dma_chan instead :( Will resend it. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/