Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753715Ab1DSIa6 (ORCPT ); Tue, 19 Apr 2011 04:30:58 -0400 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:40659 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153Ab1DSIa4 (ORCPT ); Tue, 19 Apr 2011 04:30:56 -0400 From: Haojian Zhuang To: Mark Brown CC: Haojian Zhuang , "sameo@linux.intel.com" , "linux-kernel@vger.kernel.org" , "dmitry.torokhov@gmail.com" , "a.zummo@towertech.it" , "johnpol@2ka.mipt.ru" , "cbou@mail.ru" , "dwmw2@infradead.org" , "lrg@slimlogic.co.uk" Date: Tue, 19 Apr 2011 01:28:23 -0700 Subject: RE: [PATCH 13/14] regulator: check name in initialization of max8925 Thread-Topic: [PATCH 13/14] regulator: check name in initialization of max8925 Thread-Index: Acv+aREbghJfqZiFRAiB1cXuP7pW8QAAltUQ Message-ID: <25B60CDC2F704E4E9D88FFD52780CB4C05CF05B4CC@SC-VEXCH1.marvell.com> References: <1303135451-26362-14-git-send-email-haojian.zhuang@marvell.com> <20110418142855.GE2466@opensource.wolfsonmicro.com> <20110418160424.GG1765@opensource.wolfsonmicro.com> <25B60CDC2F704E4E9D88FFD52780CB4C05CF05B424@SC-VEXCH1.marvell.com> <20110419080919.GC16357@opensource.wolfsonmicro.com> In-Reply-To: <20110419080919.GC16357@opensource.wolfsonmicro.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p3J8V3xA012184 Content-Length: 1112 Lines: 30 >-----Original Message----- >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] >Sent: 2011??4??19?? 4:09 PM >To: Haojian Zhuang >Cc: Haojian Zhuang; sameo@linux.intel.com; linux-kernel@vger.kernel.org; >dmitry.torokhov@gmail.com; a.zummo@towertech.it; johnpol@2ka.mipt.ru; >cbou@mail.ru; dwmw2@infradead.org; lrg@slimlogic.co.uk >Subject: Re: [PATCH 13/14] regulator: check name in initialization of >max8925 > >On Mon, Apr 18, 2011 at 07:42:09PM -0700, Haojian Zhuang wrote: >> Machine driver: >> Platform data: >> .regulator[0] = xxx >> .regulator[1] = xxx > >> The index of regulator array is id of buck and ldo. >> There's issue in max8925_core.c since we can't assume regulator[0] >always declared in machine driver. > >What is the issue? It's trivial to skip the regulator if the data is >null. It skiped all regulators if regulator[0] isn't decleared. (pdata == NULL) || (pdata->regulator[0] == NULL) So it's a bug. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?