Message-ID: <4DAD72A7.90904@cam.ac.uk>
Date: Tue, 19 Apr 2011 12:31:51 +0100
From: Jonathan Cameron <jic23@cam.ac.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20110122 Lightning/1.0b3pre Thunderbird/3.1.7
MIME-Version: 1.0
To: Rusty Russell <rusty@rustcorp.com.au>
CC: linux-kernel@vger.kernel.org, greg@kroah.com, adobriyan@gmail.com
Subject: Re: [PATCH 1/3] Add a usr_strtobool function matching semantics of
 existing in kernel equivalents
References: <1300973025-32497-1-git-send-email-jic23@cam.ac.uk> <1300973025-32497-2-git-send-email-jic23@cam.ac.uk> <87oc433tuw.fsf@rustcorp.com.au>
In-Reply-To: <87oc433tuw.fsf@rustcorp.com.au>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 870
Lines: 25

On 04/19/11 02:36, Rusty Russell wrote:
> On Thu, 24 Mar 2011 13:23:43 +0000, Jonathan Cameron <jic23@cam.ac.uk> wrote:
>> This is a renamed and relocated fixed version of previous kstrtobool RFC
> 
> Please just call it strtobool, usr_ implies it's a user pointer.
Will do. I guess that is still distinct enough from kstrto* to avoid
anyone expecting the semantics from this one.
> 
> And there's no need to introduce a new var in debugfs, just do:
> 
> 	if (strtobool(buf, &bv) == 0)
> 		*val = bv;
Excellent point.
> 
> And yes, I'll take it for the param stuff.
Thanks. New version coming shortly.
> 
> Thanks,
> Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/