Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710Ab1DSRHt (ORCPT ); Tue, 19 Apr 2011 13:07:49 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:55403 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753649Ab1DSRHs (ORCPT ); Tue, 19 Apr 2011 13:07:48 -0400 Date: Tue, 19 Apr 2011 18:08:29 +0100 From: Alan Cox To: Anton Vorontsov Cc: Grant Likely , Jean Delvare , LKML , Jamie Iles , Mark Brown , arnd@arndb.de Subject: Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins Message-ID: <20110419180829.56daccd0@lxorguk.ukuu.org.uk> In-Reply-To: <20110419164048.GA30346@oksana.dev.rtsoft.ru> References: <20110419145303.111aead7@endymion.delvare> <20110419155406.1da0e7fb@lxorguk.ukuu.org.uk> <20110419165746.2857c56f@lxorguk.ukuu.org.uk> <20110419164048.GA30346@oksana.dev.rtsoft.ru> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 20 > How about exporting some bus/device-type neutral probe function, like > we do in drivers/ata/pata_platform.c ? Not sure you want to be using resources as the basic currency, nor do you want your generic code doing the request_region stuff. That was a nasty mistake we made in the IDE code. Maybe the platform code should do that bit, but the generic stuff not - in the PCI case the caller will have done pci_request_* itself and chances are several of the resources are the same pci device resource and different offsets so doing request_resource on them will blow up. Concept looks good Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/