Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717Ab1DSUMK (ORCPT ); Tue, 19 Apr 2011 16:12:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44391 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945Ab1DSUMI (ORCPT ); Tue, 19 Apr 2011 16:12:08 -0400 From: Alex Williamson Subject: [PATCH v2 0/2] Store and load PCI device saved state across function resets To: linux-pci@vger.kernel.org, kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, alex.williamson@redhat.com, jan.kiszka@siemens.com, avi@redhat.com, jbarnes@virtuousgeek.org Date: Tue, 19 Apr 2011 14:12:04 -0600 Message-ID: <20110419200912.3739.22895.stgit@s20.home> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 35 v1 -> v2: Make the pointer passed around less opaque for type safety. Bug https://bugs.launchpad.net/qemu/+bug/754591 is caused because the KVM module attempts to do a pci_save_state() before assigning the device to a VM, expecting that the saved state will remain valid until we release the device. This is in conflict with our need to reset devices using PCI sysfs during a VM reset to quiesce the device. Any calls to pci_reset_function() will overwrite the device saved stated prior to reset, and reload and invalidate the state after. KVM then ends up trying to restore the state, but it's already invalid, so the device ends up with reset values. This series adds a mechanism to pull the saved state off the struct pci_dev and reload it later. Thanks, Alex --- Alex Williamson (2): KVM: Use pci_store/load_saved_state() around VM device usage PCI: Add interfaces to store and load the device saved state drivers/pci/pci.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++ include/linux/kvm_host.h | 1 include/linux/pci.h | 4 ++ virt/kvm/assigned-dev.c | 8 ++-- 4 files changed, 104 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/