Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474Ab1DSWXw (ORCPT ); Tue, 19 Apr 2011 18:23:52 -0400 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:20136 "EHLO VA3EHSOBE007.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751617Ab1DSWXu convert rfc822-to-8bit (ORCPT ); Tue, 19 Apr 2011 18:23:50 -0400 X-SpamScore: -30 X-BigFish: VPS-30(zz1803M9371O542M1432N98dK4015Lzz1202hzz8275bh8275dhz2dh95h668h839h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: KIP:(null);UIP:(null);IPVD:NLI;H:xsj-gw1;RD:unknown-60-83.xilinx.com;EFVD:NLI X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-Class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH] tty/serial: add support for Xilinx PS UART Date: Tue, 19 Apr 2011 16:22:00 -0600 In-Reply-To: <20110419221530.7370d013@lxorguk.ukuu.org.uk> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] tty/serial: add support for Xilinx PS UART Thread-Index: Acv+1sssSnFxRt9QTa61MFxv9kDe+AABt4FQ References: <20110419221530.7370d013@lxorguk.ukuu.org.uk> From: John Linn To: Alan Cox CC: , X-OriginalArrivalTime: 19 Apr 2011 22:21:54.0643 (UTC) FILETIME=[30494A30:01CBFEE0] X-RCIS-Action: ALLOW Message-ID: <8d05c32c-9ff1-4eda-9563-6857ede6541a@VA3EHSMHS020.ehs.local> X-OriginatorOrg: xilinx.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1944 Lines: 54 > -----Original Message----- > From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk] > Sent: Tuesday, April 19, 2011 3:16 PM > To: John Linn > Cc: linux-kernel@vger.kernel.org; linux-serial@vger.kernel.org > Subject: Re: [PATCH] tty/serial: add support for Xilinx PS UART > > On Tue, 19 Apr 2011 14:14:52 -0600 > John Linn wrote: > > > The Xilinx PS Uart is used on the new ARM based SoC. This > > UART is not compatible with others such that a seperate > > driver is required. > > Joyous. I wish people would standardise. > > > + 213 = /dev/ttyPS0 Xilinx PS serial port 0 > > + 214 = /dev/ttyPS1 Xilinx PS serial port 1 > > + 215 = /dev/ttyPS2 Xilinx PS serial port 2 > > + 216 = /dev/ttyPS3 Xilinx PS serial port 3 > > Is there a specific reason you need fixed minor numbers ? If not please > use a dynamic range and keep Linus happy. Hi Alan, I hope you don't mind me asking a bit more to better understand. Here's my concerns (maybe not valid). It seems like since this is a console it can get hard to debug with dynamic nodes for this driver. This driver is for an embedded device where we don't want to require udev or mdev to assign nodes. It seems like the static device nodes are typical for serial consoles in the drivers. I'm still digging in on the subject. Thanks, John This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/