Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754916Ab1DSWhV (ORCPT ); Tue, 19 Apr 2011 18:37:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079Ab1DSWhT (ORCPT ); Tue, 19 Apr 2011 18:37:19 -0400 Date: Tue, 19 Apr 2011 15:37:03 -0700 From: Chris Wright To: Alex Williamson Cc: Chris Wright , pugs@ieee.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, qemu-devel@nongnu.org, aafabbri@cisco.com, dwang2@cisco.com, benve@cisco.com Subject: Re: [PATCH] vfio: Add an ioctl to reset the device Message-ID: <20110419223703.GQ12133@x200.localdomain> References: <20110419203234.4254.94914.stgit@s20.home> <20110419220743.GO12133@x200.localdomain> <1303251751.3110.129.camel@x201> <20110419222626.GP12133@x200.localdomain> <1303252237.3110.131.camel@x201> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1303252237.3110.131.camel@x201> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 28 * Alex Williamson (alex.williamson@redhat.com) wrote: > On Tue, 2011-04-19 at 15:26 -0700, Chris Wright wrote: > > * Alex Williamson (alex.williamson@redhat.com) wrote: > > > On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote: > > > > * Alex Williamson (alex.williamson@redhat.com) wrote: > > > > > When using VFIO to assign a device to a guest, we want to make sure > > > > > the device is quiesced on VM reset to stop all DMA within the guest > > > > > mapped memory. Add an ioctl which just calls pci_reset_function() > > > > > and returns whether it succeeds. > > > > > > > > Shouldn't there be a reset when binding/unbinding vfio to/from a pci > > > > device? > > > > > > There's already one when the /dev/vfioX file is opened, we should add > > > another on release, and probably add the same PCI save state store/load > > > that I'm proposing for KVM across those. Thanks, > > > > Hmm, I looked and didn't see it, hence the question. > > vfio_open() -> pci_reset_function() > https://github.com/pugs/vfio-linux-2.6/blob/vfio/drivers/vfio/vfio_main.c Got it, thanks Alex. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/