Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [PATCH] tty/serial: add support for Xilinx PS UART
Date: Tue, 19 Apr 2011 17:47:24 -0600
In-Reply-To: <20110419234230.GA21209@kroah.com>
Thread-Topic: [PATCH] tty/serial: add support for Xilinx PS UART
Thread-Index: Acv+63jfMMTdwgeRTN66r4XorBwVgwAAG35g
References: <e35578a9-909d-4594-bbe4-41d89b5f9b3e@VA3EHSMHS014.ehs.local> <20110419221530.7370d013@lxorguk.ukuu.org.uk> <8d05c32c-9ff1-4eda-9563-6857ede6541a@VA3EHSMHS020.ehs.local> <20110419232141.GA27491@kroah.com> <68925dd6-03b8-48af-9f96-0a3f611712e1@VA3EHSMHS020.ehs.local> <20110419234230.GA21209@kroah.com>
From: John Linn <John.Linn@xilinx.com>
To: Greg KH <greg@kroah.com>
CC: Alan Cox <alan@lxorguk.ukuu.org.uk>, <linux-kernel@vger.kernel.org>,
        <linux-serial@vger.kernel.org>
Message-ID: <bba0eb69-c082-48a9-9d8e-3034e66bc9d4@VA3EHSMHS018.ehs.local>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3988
Lines: 115

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Tuesday, April 19, 2011 5:43 PM
> To: John Linn
> Cc: Alan Cox; linux-kernel@vger.kernel.org; linux-
> serial@vger.kernel.org
> Subject: Re: [PATCH] tty/serial: add support for Xilinx PS UART
> 
> On Tue, Apr 19, 2011 at 05:39:30PM -0600, John Linn wrote:
> > > -----Original Message-----
> > > From: Greg KH [mailto:greg@kroah.com]
> > > Sent: Tuesday, April 19, 2011 5:22 PM
> > > To: John Linn
> > > Cc: Alan Cox; linux-kernel@vger.kernel.org; linux-
> > > serial@vger.kernel.org
> > > Subject: Re: [PATCH] tty/serial: add support for Xilinx PS UART
> > >
> > > On Tue, Apr 19, 2011 at 04:22:00PM -0600, John Linn wrote:
> > > > > -----Original Message-----
> > > > > From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk]
> > > > > Sent: Tuesday, April 19, 2011 3:16 PM
> > > > > To: John Linn
> > > > > Cc: linux-kernel@vger.kernel.org; linux-serial@vger.kernel.org
> > > > > Subject: Re: [PATCH] tty/serial: add support for Xilinx PS
UART
> > > > >
> > > > > On Tue, 19 Apr 2011 14:14:52 -0600
> > > > > John Linn <john.linn@xilinx.com> wrote:
> > > > >
> > > > > > The Xilinx PS Uart is used on the new ARM based SoC. This
> > > > > > UART is not compatible with others such that a seperate
> > > > > > driver is required.
> > > > >
> > > > > Joyous. I wish people would standardise.
> > > > >
> > > > > > +		 213 = /dev/ttyPS0		Xilinx PS serial
> > port 0
> > > > > > +		 214 = /dev/ttyPS1		Xilinx PS serial
> > port 1
> > > > > > +		 215 = /dev/ttyPS2		Xilinx PS serial
> > port 2
> > > > > > +		 216 = /dev/ttyPS3		Xilinx PS serial
> > port 3
> > > > >
> > > > > Is there a specific reason you need fixed minor numbers ? If
> not
> > > > please
> > > > > use a dynamic range and keep Linus happy.
> > > >
> > > > Hi Alan,
> > > >
> > > > I hope you don't mind me asking a bit more to better understand.
> > > Here's
> > > > my
> > > > concerns (maybe not valid).
> > > >
> > > > It seems like since this is a console it can get hard to debug
> with
> > > > dynamic
> > > > nodes for this driver.
> > > >
> > > > This driver is for an embedded device where we don't want to
> require
> > > > udev
> > > > or mdev to assign nodes.
> > >
> > > Why not use devtmpfs?  There's no need to use udev or mdev at all.
> > >
> >
> > Hi Greg,
> >
> > Reading up on it a bit as I'm not an expert on it (like you).
> > It's not clear to me what the device driver uses for it's
major/minor
> in
> > this case.
> >
> > Maybe it doesn't matter, the driver can use ttyS0 and then it gets
> > deleted later if you want to change it.
> >
> > The only reason we didn't just use ttyS0 was that it's not a 8250
> really
> > and since we have are an FPGA people can add real 8250s in soft
logic
> > and then the system would get confusing.
> 
> No, the point is that you don't care about the major/minor number, as
> userspace can open the proper named device node, with no need for udev
> at all.  And you can dynamically allocate your major/minor number for
> your device and it all "just works".
> 
> So please follow what Alan said to do, there's no excuse that you have
> to use udev to take advantage of dynamice device numbers on embedded
> systems anymore.
> 

Great, I will dig into it more and give it a test.  Learn something new 
everyday in Linux.

Thanks for clarifying.
John

> thanks,
> 
> greg k-h


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/