Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124Ab1DTCs6 (ORCPT ); Tue, 19 Apr 2011 22:48:58 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:59798 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737Ab1DTCs4 (ORCPT ); Tue, 19 Apr 2011 22:48:56 -0400 Subject: Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards From: James Bottomley To: KOSAKI Motohiro Cc: Christoph Lameter , Pekka Enberg , Michal Hocko , Andrew Morton , Hugh Dickins , linux-mm@kvack.org, LKML , linux-parisc@vger.kernel.org, David Rientjes In-Reply-To: <20110420102314.4604.A69D9226@jp.fujitsu.com> References: <1303249716.11237.26.camel@mulgrave.site> <20110420102314.4604.A69D9226@jp.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 Apr 2011 21:48:53 -0500 Message-ID: <1303267733.11237.42.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2308 Lines: 70 On Wed, 2011-04-20 at 10:23 +0900, KOSAKI Motohiro wrote: > > On Tue, 19 Apr 2011, James Bottomley wrote: > > > > > > Which part of me telling you that you will break lots of other things in > > > > the core kernel dont you get? > > > > > > I get that you tell me this ... however, the systems that, according to > > > you, should be failing to get to boot prompt do, in fact, manage it. > > > > If you dont use certain subsystems then it may work. Also do you run with > > debuggin on. > > > > The following patch is I think what would be needed to fix it. > > I'm worry about this patch. A lot of mm code assume !NUMA systems > only have node 0. Not only SLUB. > > I'm not sure why this unfortunate mismatch occur. but I think DISCONTIG > hacks makes less sense. Can we consider parisc turn NUMA on instead? Well, you mean a patch like this? It won't build ... obviously we need some more machinery CC arch/parisc/kernel/asm-offsets.s In file included from include/linux/sched.h:78, from arch/parisc/kernel/asm-offsets.c:31: include/linux/topology.h:212:2: error: #error Please define an appropriate SD_NODE_INIT in include/asm/topology.h!!! In file included from include/linux/sched.h:78, from arch/parisc/kernel/asm-offsets.c:31: include/linux/topology.h: In function 'numa_node_id': include/linux/topology.h:255: error: implicit declaration of function 'cpu_to_node' James --- diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig index 69ff049..ffe4058 100644 --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -261,6 +261,9 @@ config HPUX bool "Support for HP-UX binaries" depends on !64BIT +config NUMA + def_bool n + config NR_CPUS int "Maximum number of CPUs (2-32)" range 2 32 diff --git a/mm/Kconfig b/mm/Kconfig index e9c0c61..17a1474 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -64,6 +64,7 @@ endchoice config DISCONTIGMEM def_bool y depends on (!SELECT_MEMORY_MODEL && ARCH_DISCONTIGMEM_ENABLE) || DISCONTIGMEM_MANUAL + select NUMA config SPARSEMEM def_bool y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/