Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251Ab1DTG7r (ORCPT ); Wed, 20 Apr 2011 02:59:47 -0400 Received: from cantor.suse.de ([195.135.220.2]:44428 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759Ab1DTG7q (ORCPT ); Wed, 20 Apr 2011 02:59:46 -0400 Date: Wed, 20 Apr 2011 08:59:43 +0200 From: Michal Hocko To: KOSAKI Motohiro Cc: Andrew Morton , Hugh Dickins , linux-mm@kvack.org, LKML Subject: Re: [PATCH followup] mm: get rid of CONFIG_STACK_GROWSUP || CONFIG_IA64 Message-ID: <20110420065943.GA18799@tiehlicka.suse.cz> References: <20110419091022.GA21689@tiehlicka.suse.cz> <20110419110956.GD21689@tiehlicka.suse.cz> <20110420093326.45EF.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110420093326.45EF.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 38 Hi Kosaki, On Wed 20-04-11 09:33:26, KOSAKI Motohiro wrote: > > While I am in the cleanup mode. We should use VM_GROWSUP rather than > > tricky CONFIG_STACK_GROWSUP||CONFIG_IA64. > > > > What do you think? > > Now, VM_GROWSUP share the same value with VM_NOHUGEPAGE. > (this trick use the fact that thp don't support any stack growup architecture) I am not sure I understand you. AFAICS, VM_GROWSUP is defined to non 0 only if CONFIG_STACK_GROWSUP||CONFIG_IA64 (include/linux/mm.h). And we use it to determine whether expand_stack_growsup[*] should be defined (in include/linux/mm.h). The patch basically unifies the way how we export expand_stack_growsup function and how define it (in mm/mmap.c). So either we should use CONFIG_STACK_GROWSUP||CONFIG_IA64 at both places or we should use VM_GROWSUP trick. I am for the later one. Am I missing something? --- [*] the previous patch renamed expand_growsup to expand_stack_growsup. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/