Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421Ab1DTITU (ORCPT ); Wed, 20 Apr 2011 04:19:20 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:55922 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768Ab1DTITS convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2011 04:19:18 -0400 MIME-Version: 1.0 In-Reply-To: <20110416154841.GA17935@S2100-06.ap.freescale.net> References: <1302116833-24540-1-git-send-email-per.forlin@linaro.org> <20110416154841.GA17935@S2100-06.ap.freescale.net> Date: Wed, 20 Apr 2011 10:19:17 +0200 Message-ID: Subject: Re: [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency From: Per Forlin To: Shawn Guo Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, Chris Ball Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2563 Lines: 62 On 16 April 2011 17:48, Shawn Guo wrote: > Hi Per, > > On Wed, Apr 06, 2011 at 09:07:01PM +0200, Per Forlin wrote: > [...] >> >> Per Forlin (12): >> ? mmc: add none blocking mmc request function >> ? mmc: mmc_test: add debugfs file to list all tests >> ? mmc: mmc_test: add test for none blocking transfers >> ? mmc: add member in mmc queue struct to hold request data >> ? mmc: add a block request prepare function >> ? mmc: move error code in mmc_block_issue_rw_rq to a separate function. >> ? mmc: add a second mmc queue request member >> ? mmc: add handling for two parallel block requests in issue_rw_rq >> ? mmc: test: add random fault injection in core.c >> ? omap_hsmmc: use original sg_len for dma_unmap_sg >> ? omap_hsmmc: add support for pre_req and post_req >> ? mmci: implement pre_req() and post_req() >> >> ?drivers/mmc/card/block.c ? ? ?| ?493 +++++++++++++++++++++++++++-------------- >> ?drivers/mmc/card/mmc_test.c ? | ?342 ++++++++++++++++++++++++++++- >> ?drivers/mmc/card/queue.c ? ? ?| ?171 +++++++++------ >> ?drivers/mmc/card/queue.h ? ? ?| ? 31 ++- >> ?drivers/mmc/core/core.c ? ? ? | ?132 ++++++++++- >> ?drivers/mmc/core/debugfs.c ? ?| ? ?5 + >> ?drivers/mmc/host/mmci.c ? ? ? | ?146 +++++++++++- >> ?drivers/mmc/host/mmci.h ? ? ? | ? ?8 + >> ?drivers/mmc/host/omap_hsmmc.c | ? 90 +++++++- >> ?include/linux/mmc/core.h ? ? ?| ? ?9 +- >> ?include/linux/mmc/host.h ? ? ?| ? 13 +- >> ?lib/Kconfig.debug ? ? ? ? ? ? | ? 11 + >> ?12 files changed, 1172 insertions(+), 279 deletions(-) >> > I'm playing the patch set and seeing the following warnings. > > ?CC ? ? ?drivers/mmc/card/block.o > drivers/mmc/card/block.c: In function ?mmc_blk_issue_rq?: > drivers/mmc/card/block.c:429:6: warning: ?status? may be used uninitialized in this function > My bad, it should be: + int status = 0; > ?CC ? ? ?drivers/mmc/core/core.o > drivers/mmc/core/core.c: In function ?mmc_request_done?: > drivers/mmc/core/core.c:163:3: warning: passing argument 2 of ?mmc_should_fail_request? from incompatible pointer type > drivers/mmc/core/core.c:129:20: note: expected ?struct mmc_data *? but argument is of type ?struct mmc_request *? The function within #ifdef CONFIG_FAIL_MMC_REQUEST is the correct one. I will update this in the next version. > > -- > Regards, > Shawn Thanks, Per -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/