Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752115Ab1DUNDa (ORCPT ); Thu, 21 Apr 2011 09:03:30 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:44183 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434Ab1DUND2 (ORCPT ); Thu, 21 Apr 2011 09:03:28 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: David Rientjes Subject: Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards Cc: kosaki.motohiro@jp.fujitsu.com, James Bottomley , Pekka Enberg , Christoph Lameter , Michal Hocko , Andrew Morton , Hugh Dickins , linux-mm@kvack.org, LKML , linux-parisc@vger.kernel.org, Ingo Molnar , x86 maintainers In-Reply-To: References: <1303317178.2587.30.camel@mulgrave.site> Message-Id: <20110421220351.9180.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Thu, 21 Apr 2011 22:03:25 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 31 > diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c > --- a/arch/parisc/mm/init.c > +++ b/arch/parisc/mm/init.c > @@ -266,8 +266,10 @@ static void __init setup_bootmem(void) > } > memset(pfnnid_map, 0xff, sizeof(pfnnid_map)); > > - for (i = 0; i < npmem_ranges; i++) > + for (i = 0; i < npmem_ranges; i++) { > + node_set_state(i, N_NORMAL_MEMORY); > node_set_online(i); > + } > #endif I'm surprised this one. If arch code doesn't initialized N_NORMAL_MEMORY, (or N_HIGH_MEMORY. N_HIGH_MEMORY == N_NORMAL_MEMORY if CONFIG_HIGHMEM=n) kswapd is created only at node0. wow. The initialization must be necessary even if !NUMA, I think. ;-) Probably we should have revisit all arch code when commit 9422ffba4a (Memoryless nodes: No need for kswapd) was introduced, at least. Thank you David. and I'm sad this multi level unforunate mismatch.... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/