Subject: Re: [PATCH 1/4] export kernel call get_task_comm().
From: J Freyensee <james_p_freyensee@linux.intel.com>
Reply-To: james_p_freyensee@linux.intel.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <gregkh@suse.de>, David Rientjes <rientjes@google.com>,
        linux-kernel@vger.kernel.org, suhail.ahmed@intel.com,
        christophe.guerard@intel.com
In-Reply-To: <20110420164621.3d817c4f.akpm@linux-foundation.org>
References: <james_p_freyensee@linux.intel.com>
	 <1303253889-10074-2-git-send-email-james_p_freyensee@linux.intel.com>
	 <alpine.DEB.2.00.1104191620360.4300@chino.kir.corp.google.com>
	 <1303258222.13457.42.camel@localhost>
	 <alpine.DEB.2.00.1104191817590.8047@chino.kir.corp.google.com>
	 <20110420014340.GA21245@suse.de> <1303323083.13457.50.camel@localhost>
	 <20110420191421.GA10306@suse.de>
	 <20110420161125.3449d4fd.akpm@linux-foundation.org>
	 <1303341368.13457.92.camel@localhost>
	 <20110420164621.3d817c4f.akpm@linux-foundation.org>
Content-Type: text/plain; charset="ISO-8859-1"
Date: Thu, 21 Apr 2011 09:12:18 -0700
Message-ID: <1303402338.13457.95.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1855
Lines: 46

On Wed, 2011-04-20 at 16:46 -0700, Andrew Morton wrote:
> On Wed, 20 Apr 2011 16:16:08 -0700
> J Freyensee <james_p_freyensee@linux.intel.com> wrote:
> 
> > On Wed, 2011-04-20 at 16:11 -0700, Andrew Morton wrote:
> > > On Wed, 20 Apr 2011 12:14:21 -0700
> > > Greg KH <gregkh@suse.de> wrote:
> > > 
> > > > > But as David pointed out, if there is work other than mine coming that
> > > > > has already been proposed, wouldn't it be good to get this patch in
> > > > > place now to start the encouragement of future eyes to just call this
> > > > > function than re-invent the wheel?
> > > > 
> > > > No, then those projects submit the patch to export this, if they happen
> > > > to get to mainline before this one does.
> > > > 
> > > > Again, don't export something unless you are using it at the time, no
> > > > "this is to be used hopefully by something in the future" type stuff
> > > > please.  Who knows if those future plans ever pan out.
> > > 
> > > Well there's an easy solution here.  Send the patch to export
> > > get_task_comm(), then send along some patches which fix
> > > 
> > > z:/usr/src/linux-2.6.39-rc4> grep -r 'current->comm' drivers | wc -l
> > > 89
> > > 
> > 
> > Andrew, so does this mean you want me to send this patch to export
> > get_task_comm() to you then?
> > 
> 
> That works.  But Greg might see us doing it, so some additional
> mergeable patches which *need* that export will keep him happy.
> 

Okay, so the pti driver I own needs that export to be able to build as a
module, so that is a start :-)

> (iow, you're being extorted into doing some kernel cleanup work)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/