Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984Ab1DURvQ (ORCPT ); Thu, 21 Apr 2011 13:51:16 -0400 Received: from mail.perches.com ([173.55.12.10]:4876 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948Ab1DURvP (ORCPT ); Thu, 21 Apr 2011 13:51:15 -0400 Subject: Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap From: Joe Perches To: Michael Chan Cc: Matthew Carlson , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <1303406280.8857.13.camel@HP1> References: <1303322263-18991-10-git-send-email-mcarlson@broadcom.com> <02bf2aa5c08514641ecbe7c39ef976918fad036c.1303367730.git.joe@perches.com> <1303406280.8857.13.camel@HP1> Content-Type: text/plain; charset="UTF-8" Date: Thu, 21 Apr 2011 10:51:14 -0700 Message-ID: <1303408274.24766.66.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 21 On Thu, 2011-04-21 at 10:18 -0700, Michael Chan wrote: > On Wed, 2011-04-20 at 23:39 -0700, Joe Perches wrote: > > @@ -4622,7 +4611,7 @@ static void tg3_tx_recover(struct tg3 *tp) > > "and include system chipset information.\n"); > > > > spin_lock(&tp->lock); > > - tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING; > > + tg3_flag_set(tp, TX_RECOVERY_PENDING); > > spin_unlock(&tp->lock); > > } > By using set_bit() now, we can eliminate the spin_lock() here. This > flag is checked much later when tg3_reset_task() is scheduled to run in > workqueue, so no memory barrier is needed either. Sure, but as a separate patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/