Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568Ab1DUTib (ORCPT ); Thu, 21 Apr 2011 15:38:31 -0400 Received: from smtp-out.google.com ([216.239.44.51]:27804 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353Ab1DUTi3 (ORCPT ); Thu, 21 Apr 2011 15:38:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=AIi47lOxf9Ix85BMuQ6/Zj9dT2rwq+rMI9fQeGgsJH6xCLtB+V8Da8EjQK3+EPYBxk bskSrCPv2Dwh/OBlXqaQ== Date: Thu, 21 Apr 2011 12:38:22 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: KOSAKI Motohiro cc: James Bottomley , Pekka Enberg , Christoph Lameter , Michal Hocko , Andrew Morton , Hugh Dickins , linux-mm@kvack.org, LKML , linux-parisc@vger.kernel.org, Ingo Molnar , x86 maintainers Subject: Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards In-Reply-To: <20110421220351.9180.A69D9226@jp.fujitsu.com> Message-ID: References: <1303317178.2587.30.camel@mulgrave.site> <20110421220351.9180.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 35 On Thu, 21 Apr 2011, KOSAKI Motohiro wrote: > > diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c > > --- a/arch/parisc/mm/init.c > > +++ b/arch/parisc/mm/init.c > > @@ -266,8 +266,10 @@ static void __init setup_bootmem(void) > > } > > memset(pfnnid_map, 0xff, sizeof(pfnnid_map)); > > > > - for (i = 0; i < npmem_ranges; i++) > > + for (i = 0; i < npmem_ranges; i++) { > > + node_set_state(i, N_NORMAL_MEMORY); > > node_set_online(i); > > + } > > #endif > > > I'm surprised this one. If arch code doesn't initialized N_NORMAL_MEMORY, > (or N_HIGH_MEMORY. N_HIGH_MEMORY == N_NORMAL_MEMORY if CONFIG_HIGHMEM=n) > kswapd is created only at node0. wow. > > The initialization must be necessary even if !NUMA, I think. ;-) > Probably we should have revisit all arch code when commit 9422ffba4a > (Memoryless nodes: No need for kswapd) was introduced, at least. > I think we may want to just convert slub (and the memory controller) to use N_HIGH_MEMORY rather than N_NORMAL_MEMORY since nothing else uses it and the generic code seems to handle N_HIGH_MEMORY for all configs appropriately. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/