Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753486Ab1DUU2A (ORCPT ); Thu, 21 Apr 2011 16:28:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47199 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298Ab1DUU17 (ORCPT ); Thu, 21 Apr 2011 16:27:59 -0400 Date: Thu, 21 Apr 2011 16:27:14 -0400 From: Dave Jones To: Sam Ravnborg Cc: Joe Perches , David Daney , Linus Torvalds , Linux Kernel , Andrew Morton , BorislavPetkov Subject: Re: annoying new gcc 4.6.0 warnings. Message-ID: <20110421202713.GA19425@redhat.com> Mail-Followup-To: Dave Jones , Sam Ravnborg , Joe Perches , David Daney , Linus Torvalds , Linux Kernel , Andrew Morton , BorislavPetkov References: <20110421192117.GA14249@redhat.com> <4DB087EC.1010205@caviumnetworks.com> <1303415086.24766.84.camel@Joe-Laptop> <20110421195801.GA15126@redhat.com> <20110421200836.GA31709@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110421200836.GA31709@merkur.ravnborg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1576 Lines: 49 On Thu, Apr 21, 2011 at 10:08:36PM +0200, Sam Ravnborg wrote: > My gcc (4.3.2) barfed over -Wno-unused-but-set-variable. > So your patch needs to check if the option is supported. I don't have a gcc older than 4.4.0. Can you try this ? Dave -- Disable the new -Wunused-but-set-variable that was added in gcc 4.6.0 It produces more false positives than useful warnings. This can still be enabled using W=1 Signed-off-by: Dave Jones diff --git a/Makefile b/Makefile index b967b96..29e16f2 100644 --- a/Makefile +++ b/Makefile @@ -559,6 +559,8 @@ ifndef CONFIG_CC_STACKPROTECTOR KBUILD_CFLAGS += $(call cc-option, -fno-stack-protector) endif +KBUILD_CFLAGS += $(call cc-option, -Wno-unused-but-set-variable) + ifdef CONFIG_FRAME_POINTER KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls else diff --git a/scripts/Makefile.build b/scripts/Makefile.build index d5f925a..30627ab 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -79,6 +79,7 @@ KBUILD_EXTRA_WARNINGS += -Wpointer-arith KBUILD_EXTRA_WARNINGS += -Wredundant-decls KBUILD_EXTRA_WARNINGS += -Wshadow KBUILD_EXTRA_WARNINGS += -Wswitch-default +KBUILD_EXTRA_WARNINGS += -Wunused-but-set-variable KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wvla,) KBUILD_CFLAGS += $(KBUILD_EXTRA_WARNINGS) endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/