Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205Ab1DUV3w (ORCPT ); Thu, 21 Apr 2011 17:29:52 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:48109 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754724Ab1DUV3u (ORCPT ); Thu, 21 Apr 2011 17:29:50 -0400 Message-ID: <4DB0A1C3.6050700@oracle.com> Date: Thu, 21 Apr 2011 14:29:39 -0700 From: Sunil Mushran User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: Theodore Tso CC: Josef Bacik , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 1/2] fs: add SEEK_HOLE and SEEK_DATA flags References: <1303414954-3315-1-git-send-email-josef@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: rcsinet13.oracle.com [148.87.113.125] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4DB0A1C8.0075:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 17 On 04/21/2011 01:45 PM, Theodore Tso wrote: > On Apr 21, 2011, at 3:42 PM, Josef Bacik wrote: >> + case SEEK_DATA: >> + case SEEK_HOLE: >> + return -EINVAL; >> } > > Maybe we should be returning EOPNOTSUPP? > > -- Ted For SEEK_HOLE yes. But we could let the default SEEK_DATA be a null-op. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/