Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279Ab1DVAe3 (ORCPT ); Thu, 21 Apr 2011 20:34:29 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:60929 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960Ab1DVAe2 (ORCPT ); Thu, 21 Apr 2011 20:34:28 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: David Rientjes Subject: Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards Cc: kosaki.motohiro@jp.fujitsu.com, James Bottomley , Pekka Enberg , Christoph Lameter , Michal Hocko , Andrew Morton , Hugh Dickins , linux-mm@kvack.org, LKML , linux-parisc@vger.kernel.org, Ingo Molnar , x86 maintainers In-Reply-To: References: <20110421221712.9184.A69D9226@jp.fujitsu.com> Message-Id: <20110422093406.FA56.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Fri, 22 Apr 2011 09:34:25 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 28 > On Thu, 21 Apr 2011, KOSAKI Motohiro wrote: > > > ia64 and mips have CONFIG_ARCH_POPULATES_NODE_MAP and it initialize > > N_NORMAL_MEMORY automatically if my understand is correct. > > (plz see free_area_init_nodes) > > > > ia64 doesn't enable CONFIG_HIGHMEM, so it never gets set via this generic > code; mips also doesn't enable it for all configs even for 32-bit. > > So we'll either want to take check_for_regular_memory() out from under > CONFIG_HIGHMEM and do it for all configs or teach slub to use > N_HIGH_MEMORY rather than N_NORMAL_MEMORY. Hey, I already told this thing. If CONFIG_HIGHMEM=n, N_HIGH_MEMORY and N_NORMAL_MEMORY are share the same value. then, node_set_state(nid, N_HIGH_MEMORY) in free_area_init_nodes() mean set both N_HIGH_MEMORY and N_NORMAL_MEMORY. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/