Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533Ab1DVJzi (ORCPT ); Fri, 22 Apr 2011 05:55:38 -0400 Received: from cantor.suse.de ([195.135.220.2]:53363 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618Ab1DVJzg (ORCPT ); Fri, 22 Apr 2011 05:55:36 -0400 Date: Fri, 22 Apr 2011 11:55:34 +0200 (CEST) From: Jiri Kosina To: Henrik Rydberg Cc: Benjamin Tissoires , Dmitry Torokhov , Stephane Chatty , PenMount , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] HID: hid-multitouch: refactor last_field_index In-Reply-To: <20110421124505.GA7916@polaris.bitmath.org> Message-ID: References: <1303388160-2814-1-git-send-email-benjamin.tissoires@enac.fr> <1303388160-2814-2-git-send-email-benjamin.tissoires@enac.fr> <20110421124505.GA7916@polaris.bitmath.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 33 On Thu, 21 Apr 2011, Henrik Rydberg wrote: > > the current implementation requires the devices to report > > HID_DG_CONTACTCOUNT to set the last_field_index value. > > However, devices reporting in serial mode (DWAV and PenMount) > > do not send this field. > > Other devices (3M) add other fields in the reports descriptor > > that are not multitouch related at the end, thus the need to > > add a special case in the default case when handling events. > > > > A first work around has been set up but with PenMount devices, > > we have reached the limit. > > > > The idea is to calculate the last_field_index by relying only on > > multitouch fields the device send. This allows us to remove > > the handling of non-multitouch events in hid-multitouch, and > > guarantee that the function mt_emit_event is always called. > > > > Signed-off-by: Benjamin Tissoires > > --- > > Reviewed-and-tested-by: Henrik Rydberg Applied, thanks guys. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/