Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756644Ab1DVUel (ORCPT ); Fri, 22 Apr 2011 16:34:41 -0400 Received: from cantor.suse.de ([195.135.220.2]:44583 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756418Ab1DVUej (ORCPT ); Fri, 22 Apr 2011 16:34:39 -0400 Date: Fri, 22 Apr 2011 22:34:34 +0200 From: Jan Kara To: Chris Mason Cc: djwong , Mingming Cao , Christoph Hellwig , Jeff Layton , Jan Kara , Dave Chinner , Joel Becker , "Martin K. Petersen" , Jens Axboe , linux-kernel , linux-fsdevel , Mingming Cao , linux-scsi , Dave Hansen Subject: Re: [RFC v2] block integrity: Stabilize(?) pages during writeback Message-ID: <20110422203434.GA2977@quack.suse.cz> References: <20110406232938.GF1110@tux1.beaverton.ibm.com> <20110407165700.GB7363@quack.suse.cz> <20110408203135.GH1110@tux1.beaverton.ibm.com> <20110411124229.47bc28f6@corrin.poochiereds.net> <1302543595-sup-4352@think> <1302569212.2580.13.camel@mingming-laptop> <20110412005719.GA23077@infradead.org> <1302742128.2586.274.camel@mingming-laptop> <20110422000226.GA22189@tux1.beaverton.ibm.com> <1303476503-sup-4141@think> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1303476503-sup-4141@think> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 28 On Fri 22-04-11 08:50:01, Chris Mason wrote: > Excerpts from Darrick J. Wong's message of 2011-04-21 20:02:26 -0400: > > Hi everyone, > > > > I've finally managed to get together a patch that seems to provide stable pages > > during writeback, or at least gets us to the point that after several days of > > running tests I don't see DIF checksum errors anymore. :) > > > > The last two pieces to go into this puzzle were (a) bio_integrity_prep needs to > > walk the process tree to find all userland ptes that map to a particular memory > > page and revoke write access, and > > Hmm, did you need the bio_integrity_prep change for all the filesystems? > This should be happening already as part of using page_mkwrite. Or more precisely page_mkclean() should do what you try to do in bio_integrity_prep()... It would certainly be interesting (bug) if you could write to the page after calling page_mkclean() without page_mkwrite() being called. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/