Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757605Ab1DXPfa (ORCPT ); Sun, 24 Apr 2011 11:35:30 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:62486 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757576Ab1DXPf0 (ORCPT ); Sun, 24 Apr 2011 11:35:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=kHG+5lS3NSpYL+u9Ov3pJwX/IevP7ytAAkKUc89+BRLnTW4xFl121pFRZ+5cFLbXEF z9boKie3DW+JchYL8Bv1CnyWKmhbzKEoMrJmVVQzYmej2vFV8hTsfuXhRkulkTQyrtRM as8NSd9/md4Gwr0JAAi4MFqzkJetYmZ5AeNM8= Message-ID: <4DB4433A.5000609@pobox.com> Date: Sun, 24 Apr 2011 11:35:22 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Igor Plyatov CC: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, stf_xl@wp.pl Subject: Re: [PATCH] ATA: pata_at91.c bugfixes References: <1303299877-12088-1-git-send-email-plyatov@gmail.com> In-Reply-To: <1303299877-12088-1-git-send-email-plyatov@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 33 On 04/20/2011 07:44 AM, Igor Plyatov wrote: > * Fix "initial_timing" structure initialisation. The "struct ata_timing" must > contain 10 members, but ".dmack_hold" member was not initialised. > * The AT91SAM9 microcontrollers use special coding scheme for SMC_SETUP, > SMC_PULSE, SMC_CYCLE registers. > Old driver operates correctly only with low master clock values, but > with high master clock it incorrectly calculates SMC values and stops > to operate, because SMC can be setup only to admissible ranges in special > format. > New code correctly calculates SMC registers values, adjusts calculated > to admissible ranges, enlarges cycles if required and converts values > into SMC's format. > * Old driver calculates CS_SETUP and CS_PULSE cycles incorrectly > because of wrong assumptions. > New code calculates: > CS_SETUP = SETUP/2 > CS_PULSE = PULSE + SETUP/2 + HOLD/2 > * This fixes allows to correctly operate with any master clock frequency. > > Signed-off-by: Igor Plyatov > --- > drivers/ata/pata_at91.c | 223 ++++++++++++++++++++++++++++++++--------------- > 1 files changed, 154 insertions(+), 69 deletions(-) FYI, the two previous "v4" patches are now applied. Based on the comments from Stanislaw, this patch would need to be updated anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/